Add enable workflow trigger endpoint #6443
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The pull request introduces a new endpoint to enable workflow triggers, along with several supporting changes to enhance error handling and integrate the new functionality into the existing system.
- Added
WorkflowTriggerModule: Integrated intocore-engine.module.tsto manage workflow triggers. - New Exception Handling: Introduced
workflow-trigger-graphql-api-exception-handler.util.tsandworkflow-trigger.exception.tsfor specific error management. - GraphQL Mutation: Added
enableWorkflowTriggerinworkflow-trigger.resolver.tsfor enabling triggers. - Service Implementation: Created
WorkflowTriggerServiceinworkflow-trigger.service.tsto handle trigger operations. - Entity Updates: Modified
workflow-version.workspace-entity.tsand addedworkflow-event-listener.workspace-entity.tsto support new trigger types and event listeners.
13 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
...ges/twenty-server/src/modules/workflow/standard-objects/workflow-version.workspace-entity.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/workflow/workflow-trigger.service.ts
Outdated
Show resolved
Hide resolved
| await workflowEventListenerRepository.delete({ | ||
| workflowId, | ||
| eventName, | ||
| }); | ||
|
|
||
| const workflowEventListener = await workflowEventListenerRepository.create({ | ||
| workflowId, | ||
| eventName, | ||
| }); | ||
|
|
||
| await workflowEventListenerRepository.save(workflowEventListener); |
There was a problem hiding this comment.
you should probably use workflowEventListenerRepository.upsert here
There was a problem hiding this comment.
@martmull unicity is not available for workspace entities yet. Adding a TODO to update that part!
| ) {} | ||
|
|
||
| @Mutation(() => Boolean) | ||
| async enableWorkflowTrigger( |
There was a problem hiding this comment.
enableWorkflowTrigger -> I don't understand the naming here
triggerWorkflow ?
There was a problem hiding this comment.
@martmull It does not really trigger the workflow. It setup the workflow trigger, so it will get triggered later.
I could rename it setupWorflowTrigger but this is not that fare from enableWorkflowTrigger. So for this one let's remain consistent with activePieces? Wdyt?
| return true; | ||
| } | ||
|
|
||
| private async executeInternalEventTrigger( |
There was a problem hiding this comment.
I don't understand the naming here, createWorkflowEventListener?
| type: FieldMetadataType.TEXT, | ||
| label: 'Name', | ||
| description: 'The workflow event listener name', | ||
| icon: 'IconPhoneCheck', |
There was a problem hiding this comment.
Are you sure about the icon?
There was a problem hiding this comment.
Nope, but I did not find a better one. Since this is a system object, does it really matters?
There was a problem hiding this comment.
no, but in that case, just remove icon: 'IconPhoneCheck',, it is not mandatory
Basic endpoint that only returns a boolean currently and overrides the previous listener.